Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 6081007: Start sorting methods in class declarations. (Closed)

Created:
9 years, 11 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org, jshin+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Start sorting methods in class declarations. A lot of our headers are a mess and aren't organized. Impose the following order on files in the base/ directory: class Blah { each public/protected/private section: typedefs; enums; static constants; ctors; dtors; methods; overridden virtual methods; data members; }; BUG=68682 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70749

Patch Set 1 #

Patch Set 2 : Revert changes to unrelated sh #

Patch Set 3 : More copyright #

Patch Set 4 : Redo with just overridden virtual methods at the end #

Patch Set 5 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+434 lines, -389 lines) Patch
M base/at_exit.h View 1 2 3 3 chunks +8 lines, -8 lines 0 comments Download
M base/base.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M base/command_line.h View 1 2 3 5 chunks +28 lines, -23 lines 0 comments Download
M base/crypto/rsa_private_key.h View 3 chunks +3 lines, -3 lines 0 comments Download
M base/crypto/signature_creator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/file_util.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M base/file_util_proxy.h View 1 2 3 7 chunks +17 lines, -16 lines 0 comments Download
M base/global_descriptors_posix.h View 1 2 3 4 chunks +5 lines, -4 lines 0 comments Download
M base/json/json_reader.h View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M base/logging.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M base/message_loop.h View 1 2 3 7 chunks +63 lines, -63 lines 0 comments Download
M base/message_pump_glib.h View 1 2 3 3 chunks +7 lines, -6 lines 0 comments Download
M base/message_pump_glib_x.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M base/message_pump_glib_x_dispatch.h View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M base/message_pump_libevent.h View 1 2 3 4 chunks +12 lines, -11 lines 0 comments Download
M base/metrics/field_trial.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M base/metrics/histogram.h View 1 2 3 4 chunks +11 lines, -8 lines 0 comments Download
M base/metrics/stats_table.h View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M base/pickle.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M base/platform_file.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
A base/platform_file.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M base/process_util.h View 1 2 3 5 chunks +9 lines, -9 lines 0 comments Download
M base/ref_counted_memory.h View 1 2 3 3 chunks +8 lines, -6 lines 0 comments Download
M base/string_piece.h View 1 2 3 4 4 chunks +16 lines, -15 lines 0 comments Download
M base/synchronization/waitable_event.h View 1 2 3 4 1 chunk +7 lines, -6 lines 0 comments Download
M base/synchronization/waitable_event_watcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/synchronization/waitable_event_watcher_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/synchronization/waitable_event_watcher_win.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M base/task_queue.h View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M base/threading/simple_thread.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M base/threading/thread.h View 1 2 3 4 chunks +7 lines, -7 lines 0 comments Download
M base/threading/watchdog.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M base/time.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M base/tracked_objects.h View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M base/values.h View 1 2 3 9 chunks +30 lines, -30 lines 0 comments Download
M base/version.h View 3 chunks +6 lines, -6 lines 0 comments Download
M gfx/gfx.gyp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M gfx/native_theme_linux.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M gfx/platform_font_gtk.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M gfx/test_suite.h View 1 2 3 2 chunks +5 lines, -43 lines 0 comments Download
A gfx/test_suite.cc View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download
M skia/ext/bitmap_platform_device_linux.h View 1 2 3 3 chunks +15 lines, -18 lines 0 comments Download
M skia/ext/convolver.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M skia/ext/platform_canvas.h View 1 2 3 5 chunks +20 lines, -21 lines 0 comments Download
M skia/ext/vector_platform_device_linux.h View 1 2 3 4 chunks +14 lines, -12 lines 0 comments Download
M webkit/plugins/npapi/plugin_host.cc View 1 2 4 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
9 years, 11 months ago (2011-01-07 01:01:01 UTC) #1
Ben Goodger (Google)
9 years, 11 months ago (2011-01-07 16:33:33 UTC) #2
OK

Powered by Google App Engine
This is Rietveld 408576698