Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 608031: Change KeyedStoreIC interface to take value, key, and receiver in registers. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/ia32/virtual-frame-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1673 matching lines...) Expand 10 before | Expand all | Expand 10 after
1684 return GetCode(NORMAL, name); 1684 return GetCode(NORMAL, name);
1685 } 1685 }
1686 1686
1687 1687
1688 Object* KeyedStoreStubCompiler::CompileStoreField(JSObject* object, 1688 Object* KeyedStoreStubCompiler::CompileStoreField(JSObject* object,
1689 int index, 1689 int index,
1690 Map* transition, 1690 Map* transition,
1691 String* name) { 1691 String* name) {
1692 // ----------- S t a t e ------------- 1692 // ----------- S t a t e -------------
1693 // -- eax : value 1693 // -- eax : value
1694 // -- ecx : key
1695 // -- edx : receiver
1694 // -- esp[0] : return address 1696 // -- esp[0] : return address
1695 // -- esp[4] : key
1696 // -- esp[8] : receiver
1697 // ----------------------------------- 1697 // -----------------------------------
1698 Label miss; 1698 Label miss;
1699 1699
1700 __ IncrementCounter(&Counters::keyed_store_field, 1); 1700 __ IncrementCounter(&Counters::keyed_store_field, 1);
1701 1701
1702 // Get the name from the stack.
1703 __ mov(ecx, Operand(esp, 1 * kPointerSize));
1704 // Check that the name has not changed. 1702 // Check that the name has not changed.
1705 __ cmp(Operand(ecx), Immediate(Handle<String>(name))); 1703 __ cmp(Operand(ecx), Immediate(Handle<String>(name)));
1706 __ j(not_equal, &miss, not_taken); 1704 __ j(not_equal, &miss, not_taken);
1707 1705
1708 // Get the object from the stack.
1709 __ mov(edx, Operand(esp, 2 * kPointerSize));
1710
1711 // Generate store field code. Trashes the name register. 1706 // Generate store field code. Trashes the name register.
1712 GenerateStoreField(masm(), 1707 GenerateStoreField(masm(),
1713 object, 1708 object,
1714 index, 1709 index,
1715 transition, 1710 transition,
1716 edx, ecx, ebx, 1711 edx, ecx, ebx,
1717 &miss); 1712 &miss);
1718 1713
1719 // Handle store cache miss. 1714 // Handle store cache miss.
1720 __ bind(&miss); 1715 __ bind(&miss);
(...skipping 483 matching lines...) Expand 10 before | Expand all | Expand 10 after
2204 __ jmp(generic_construct_stub, RelocInfo::CODE_TARGET); 2199 __ jmp(generic_construct_stub, RelocInfo::CODE_TARGET);
2205 2200
2206 // Return the generated code. 2201 // Return the generated code.
2207 return GetCode(); 2202 return GetCode();
2208 } 2203 }
2209 2204
2210 2205
2211 #undef __ 2206 #undef __
2212 2207
2213 } } // namespace v8::internal 2208 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/ia32/virtual-frame-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698