Issue 608014: Normalize the object before updating getter/setter info.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 608014: Normalize the object before updating getter/setter info. (Closed)

Created:
10 years, 10 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Normalize the object before updating getter/setter info. BUG=612 Committed: http://code.google.com/p/v8/source/detail?r=3880

Patch Set 2 : Last round #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -0 lines)			Patch
	M	src/objects.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	A	test/mjsunit/regress/regress-612.js	View	1	1 chunk	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/608014/diff/1/3 File test/mjsunit/regress/regress-612.js (right): http://codereview.chromium.org/608014/diff/1/3#newcode28 test/mjsunit/regress/regress-612.js:28: obj = {} Could you add a comment ...

10 years, 10 months ago (2010-02-16 18:49:08 UTC) #2

antonm

10 years, 10 months ago (2010-02-17 06:58:22 UTC) #3

Thanks a lot for review, Mads.  Submitted.

http://codereview.chromium.org/608014/diff/1/3
File test/mjsunit/regress/regress-612.js (right):

http://codereview.chromium.org/608014/diff/1/3#newcode28
test/mjsunit/regress/regress-612.js:28: obj = {}
On 2010/02/16 18:49:08, Mads Ager wrote:
> Could you add a comment in the beginning of this file that this is a
regression
> test for issue 612 and add a URL for the v8 issue?

Done.  Let me know if you want it changed.

Expand Messages | Collapse Messages

Issue 608014: Normalize the object before updating getter/setter info. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Last round #

Messages