TabStrip Cleanup

TabStrip Cleanup

This patch is a cleanup of existing Tab code, as per the review comments of 5572007 Patch Set 2.  Some of the comments from that review apply to pre-existing code, and so I separated out those changes into their own CL (this one).

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71323

[wyck, 2010-12-23 19:35:49]

Please review.  (Refer to http://codereview.chromium.org/5572007 as necessary)

[sky, 2011-01-04 20:01:00]

Change the following, and LGTM

http://codereview.chromium.org/6080002/diff/7001/chrome/browser/ui/views/tabs...
File chrome/browser/ui/views/tabs/tab.h (right):

http://codereview.chromium.org/6080002/diff/7001/chrome/browser/ui/views/tabs...
chrome/browser/ui/views/tabs/tab.h:75: void PaintIcon(gfx::Canvas* canvas);
Move this between 81 and 82. Also, no need to have the comment.

[wyck, 2011-01-05 01:37:14]

OK Thanks.  And FYI: I'm delayed until Google moves into the new Waterloo
office : Jan 10, 2011.

On Tue, Jan 4, 2011 at 3:01 PM, <sky@chromium.org> wrote:

> Change the following, and LGTM
>
>
>
>
http://codereview.chromium.org/6080002/diff/7001/chrome/browser/ui/views/tabs...
> File chrome/browser/ui/views/tabs/tab.h (right):
>
>
>
http://codereview.chromium.org/6080002/diff/7001/chrome/browser/ui/views/tabs...
> chrome/browser/ui/views/tabs/tab.h:75: void PaintIcon(gfx::Canvas*
> canvas);
> Move this between 81 and 82. Also, no need to have the comment.
>
> http://codereview.chromium.org/6080002/
>

[wyck, 2011-01-11 20:23:49]

Ready to go.

http://codereview.chromium.org/6080002/diff/7001/chrome/browser/ui/views/tabs...
File chrome/browser/ui/views/tabs/tab.h (right):

http://codereview.chromium.org/6080002/diff/7001/chrome/browser/ui/views/tabs...
chrome/browser/ui/views/tabs/tab.h:75: void PaintIcon(gfx::Canvas* canvas);
On 2011/01/04 20:01:01, sky wrote:
> Move this between 81 and 82. Also, no need to have the comment.

Done.

[sky, 2011-01-11 21:12:58]

LGTM