This makes net_perftests build and run on Linux.

This makes net_perftests build and run on Linux.

BUG=3065

[Dean McNamee, 2008-10-02 15:10:32]

Good enough for me.  I don't know in practice if the fadvise will really have
the kernel unbuffer it, but the current Windows code doesn't really seem like
exact science either...

http://codereview.chromium.org/6080/diff/1/3
File net/disk_cache/disk_cache_perftest.cc (right):

http://codereview.chromium.org/6080/diff/1/3#newcode75
Line 75: }
Personally, I do these without the { }, so

if (fd < 0)
  return false;
...

Doesn't really matter much though.

[please use my chromium address, 2008-10-02 15:20:40]

On 2008/10/02 15:10:32, Dean McNamee wrote:
> http://codereview.chromium.org/6080/diff/1/3
> File net/disk_cache/disk_cache_perftest.cc (right):
> 
> http://codereview.chromium.org/6080/diff/1/3#newcode75
> Line 75: }
> Personally, I do these without the { }, so
> 
> if (fd < 0)
>   return false;
> ...

No problem, changed. It takes a bit less space on screen now.

[sgk, 2008-10-02 20:07:25]

lgtm

[Mark Mentovai, 2008-10-02 20:31:22]

LGTM also, I can't check this in right now though because we're in the middle of
merge fun.

[please use my chromium address, 2008-10-08 10:30:55]

On 2008/10/02 20:31:22, Mark Mentovai wrote:
> LGTM also, I can't check this in right now though because we're in the middle
of
> merge fun.

Tree is now open. Please take a look.

[Evan Martin, 2008-10-13 17:41:11]

I'm looking at this now.

[Evan Martin, 2008-10-13 18:37:18]

I had to remove unistd.h for Windows.

r3298