Added a test to make sure the app store redirect issue (see bug) doesn't

Added a test to make sure the app store redirect issue (see bug) doesn't
regress.

Also reenabled a test that I think is no longer flaky.

BUG=61757, 58810
TEST=n/a

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70475

[Charlie Reis, 2011-01-05 00:57:25]

Thanks-- this will be useful as we make progress on issue 65953.

http://codereview.chromium.org/6078012/diff/2001/chrome/browser/extensions/ap...
File chrome/browser/extensions/app_process_apitest.cc (right):

http://codereview.chromium.org/6078012/diff/2001/chrome/browser/extensions/ap...
chrome/browser/extensions/app_process_apitest.cc:144: // 2. page1 redirects to a
page2 outside the app extent
Maybe add "(i.e., /server-redirect)" to make it clear what page2 is.

http://codereview.chromium.org/6078012/diff/2001/chrome/browser/extensions/ap...
chrome/browser/extensions/app_process_apitest.cc:157: // Open two tabs in the
app, one outside it.
Copy/paste bug.  (There's no third tab outside the app.)

http://codereview.chromium.org/6078012/diff/2001/chrome/browser/extensions/ap...
chrome/browser/extensions/app_process_apitest.cc:176: while
(controller.GetActiveEntry()->url().path().find("empty.html") ==
"empty.html" is in the redirect URL, too.  Could we end up exiting this loop
before we get to the last page?

[Matt Perry, 2011-01-05 01:14:47]

http://codereview.chromium.org/6078012/diff/2001/chrome/browser/extensions/ap...
File chrome/browser/extensions/app_process_apitest.cc (right):

http://codereview.chromium.org/6078012/diff/2001/chrome/browser/extensions/ap...
chrome/browser/extensions/app_process_apitest.cc:144: // 2. page1 redirects to a
page2 outside the app extent
On 2011/01/05 00:57:25, creis wrote:
> Maybe add "(i.e., /server-redirect)" to make it clear what page2 is.

Done.

http://codereview.chromium.org/6078012/diff/2001/chrome/browser/extensions/ap...
chrome/browser/extensions/app_process_apitest.cc:157: // Open two tabs in the
app, one outside it.
On 2011/01/05 00:57:25, creis wrote:
> Copy/paste bug.  (There's no third tab outside the app.)

Done.

http://codereview.chromium.org/6078012/diff/2001/chrome/browser/extensions/ap...
chrome/browser/extensions/app_process_apitest.cc:176: while
(controller.GetActiveEntry()->url().path().find("empty.html") ==
On 2011/01/05 00:57:25, creis wrote:
> "empty.html" is in the redirect URL, too.  Could we end up exiting this loop
> before we get to the last page?

Good catch! Done.

[Charlie Reis, 2011-01-05 01:16:50]

LGTM!

[Paweł Hajdan Jr., 2011-01-05 08:14:19]

Drive-by with a test comment. Could you do a little follow-up CL?

http://codereview.chromium.org/6078012/diff/7001/chrome/browser/extensions/ap...
File chrome/browser/extensions/app_process_apitest.cc (right):

http://codereview.chromium.org/6078012/diff/7001/chrome/browser/extensions/ap...
chrome/browser/extensions/app_process_apitest.cc:174: // Wait until the second
tab finishes its redirect train (2 hops).
Hey, did you want NavigateToURLBlockUntilNavigationsComplete? It allows you to
wait for two navigations instead of one in an elegant way.