gtk: Cleanup BookmarkBarGtk class.

gtk: Cleanup BookmarkBarGtk class.

- Remove unused constants.
- Remove explicit keyword from constructor.
- Move FRIEND_ macros to private section.

BUG=None
TEST=trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70245

[tfarina, 2010-12-27 18:22:06]

Please, take a look.

[Evan Stade, 2010-12-28 20:46:51]

thanks for doing this.

http://codereview.chromium.org/6078009/diff/4001/chrome/browser/gtk/bookmark_...
File chrome/browser/gtk/bookmark_bar_gtk.h (right):

http://codereview.chromium.org/6078009/diff/4001/chrome/browser/gtk/bookmark_...
chrome/browser/gtk/bookmark_bar_gtk.h:99: // Overridden from AnimationDelegate:
was there some decree I missed that this is the preferred style?

[tfarina, 2010-12-28 20:51:14]

http://codereview.chromium.org/6078009/diff/4001/chrome/browser/gtk/bookmark_...
File chrome/browser/gtk/bookmark_bar_gtk.h (right):

http://codereview.chromium.org/6078009/diff/4001/chrome/browser/gtk/bookmark_...
chrome/browser/gtk/bookmark_bar_gtk.h:99: // Overridden from AnimationDelegate:
On 2010/12/28 20:46:52, Evan Stade wrote:
> was there some decree I missed that this is the preferred style?

Nope, I just use it everywhere. There are two other forms without the "----" in
the end that I have seen, which is methods and implementation(s). If you are
strong about this I will revert this particular change, although I really have a
preference for using "Overridden...".

[Evan Stade, 2010-12-28 20:54:47]

yes, I like the current style because IMO the hyphens assist in visual parsing.
I could care less about "implementation" vs. "overridden from".

aside from that, LGTM