Issue 6078001: Modify inclusion to use system icu headers when -Duse_system_icu=1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6078001: Modify inclusion to use system icu headers when -Duse_system_icu=1 (Closed)

Created:
10 years ago by Mike Gilbert

Modified:
9 years, 7 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Modify inclusion to use system icu headers when -Duse_system_icu=1 The gyp definition should take care of the default case -Duse_system_icu=0 by prepending third_party/icu/public/i18n to the inclusion search path. See downstream gentoo bug report: http://bugs.gentoo.org/show_bug.cgi?id=348944 Contributed by Mike Gilbert <floppymaster@gmail.com>;. BUG=none TEST=Remove third_party/icu/public/i18n/unicode/usearch.h and build with -Duse_system_icu=1. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69811

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	webkit/plugins/ppapi/ppb_pdf_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, thanks! I'll land this soon.

Expand Messages | Collapse Messages