Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1352)

Unified Diff: chrome/browser/chromeos/external_metrics.cc

Issue 6077013: Add support for collecting non-Chrome crash stats in Chrome OS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/external_metrics.h ('k') | chrome/browser/chromeos/external_metrics_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/external_metrics.cc
===================================================================
--- chrome/browser/chromeos/external_metrics.cc (revision 71358)
+++ chrome/browser/chromeos/external_metrics.cc (working copy)
@@ -18,7 +18,9 @@
#include "base/metrics/histogram.h"
#include "base/perftimer.h"
#include "base/time.h"
+#include "chrome/browser/browser_process.h"
#include "chrome/browser/browser_thread.h"
+#include "chrome/browser/metrics/metrics_service.h"
#include "chrome/browser/metrics/user_metrics.h"
// Steps to add an action.
@@ -80,6 +82,18 @@
NewRunnableMethod(this, &ExternalMetrics::RecordActionUI, action));
}
+void ExternalMetrics::RecordCrashUI(const std::string& crash_kind) {
+ if (g_browser_process && g_browser_process->metrics_service()) {
+ g_browser_process->metrics_service()->LogChromeOSCrash(crash_kind);
+ }
+}
+
+void ExternalMetrics::RecordCrash(const std::string& crash_kind) {
+ BrowserThread::PostTask(
+ BrowserThread::UI, FROM_HERE,
+ NewRunnableMethod(this, &ExternalMetrics::RecordCrashUI, crash_kind));
+}
+
void ExternalMetrics::RecordHistogram(const char* histogram_data) {
int sample, min, max, nbuckets;
char name[128]; // length must be consistent with sscanf format below.
@@ -194,6 +208,8 @@
char* value = reinterpret_cast<char*>(p + 1);
if (test_recorder_ != NULL) {
test_recorder_(name, value);
+ } else if (strcmp(name, "crash") == 0) {
+ RecordCrash(value);
} else if (strcmp(name, "histogram") == 0) {
RecordHistogram(value);
} else if (strcmp(name, "linearhistogram") == 0) {
« no previous file with comments | « chrome/browser/chromeos/external_metrics.h ('k') | chrome/browser/chromeos/external_metrics_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698