Add support for collecting non-Chrome crash stats in Chrome OS

chrome/browser/metrics/metrics_service.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines a service that collects information about the user
 // experience in order to help improve future versions of the app.
 
 #ifndef CHROME_BROWSER_METRICS_METRICS_SERVICE_H_
 #define CHROME_BROWSER_METRICS_METRICS_SERVICE_H_
 #pragma once
@@ skipping 108 matching lines @@
   // at shutdown, but we can do it as we reduce the list as well.
   void StoreUnsentLogs();
 
 #if defined(OS_CHROMEOS)
   // Returns the hardware class of the Chrome OS device (e.g.,
   // hardware qualification ID), or "unknown" if the hardware class is
   // not available.  The hardware class identifies the configured
   // system components such us CPU, WiFi adapter, etc.  Note that this
   // routine invokes an external utility to determine the hardware
   // class.
   static std::string GetHardwareClass();

[petkov, 2011/01/06 18:50:36]

I think this method declaration needs to be removed (there's no implementation
AFAICT) -- you may as well clean this up.

[kmixter1, 2011/01/14 00:07:02]

Done.

 
   // Start the external metrics service, which collects metrics from Chrome OS
   // and passes them to UMA.
   void StartExternalMetrics();
 #endif
 
   bool recording_active() const;
   bool reporting_active() const;
 
+#if defined(OS_CHROMEOS)

[petkov, 2011/01/06 18:50:36]

why don't you fold this into the ifdef above rather than introduce a new ifdef?

[kmixter1, 2011/01/14 00:07:02]

Done.

+  // Records a Chrome OS crash.
+  void LogChromeOSCrash(const std::string &crash_type);
+#endif
+
  private:
   // The MetricsService has a lifecycle that is stored as a state.
   // See metrics_service.cc for description of this lifecycle.
   enum State {
     INITIALIZED,            // Constructor was called.
     INIT_TASK_SCHEDULED,    // Waiting for deferred init tasks to complete.
     INIT_TASK_DONE,         // Waiting for timer to send initial log.
     INITIAL_LOG_READY,      // Initial log generated, and waiting for reply.
     SEND_OLD_INITIAL_LOGS,  // Sending unsent logs from previous session.
     SENDING_OLD_LOGS,       // Sending unsent logs from previous session.
@@ skipping 343 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, CorruptSizeOfLogList);
   FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, CorruptChecksumOfLogList);
   FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, ClientIdGeneratesAllZeroes);
   FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, ClientIdGeneratesCorrectly);
   FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, ClientIdCorrectlyFormatted);
 
   DISALLOW_COPY_AND_ASSIGN(MetricsService);
 };
 
 #endif  // CHROME_BROWSER_METRICS_METRICS_SERVICE_H_