Add support for collecting non-Chrome crash stats in Chrome OS

chrome/browser/chromeos/external_metrics.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/external_metrics.h"
 
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>
 #include <sys/file.h>
 #include <sys/stat.h>
 #include <sys/types.h>
 
 #include "base/basictypes.h"
 #include "base/eintr_wrapper.h"
 #include "base/metrics/histogram.h"
 #include "base/perftimer.h"
 #include "base/time.h"
+#include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_thread.h"
+#include "chrome/browser/metrics/metrics_service.h"
 #include "chrome/browser/metrics/user_metrics.h"
 
 // Steps to add an action.
 //
 // 1. Enter a helper function that calls UserMetrics::RecordAction.
 //
 // 2. Add a line for that function in InitializeUserActions.
 //
 // 3. Enjoy the recompilation.
 //
@@ skipping 41 matching lines @@
   }
 }
 
 void ExternalMetrics::RecordAction(const char* action) {
   std::string action_string(action);
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       NewRunnableMethod(this, &ExternalMetrics::RecordActionUI, action));
 }
 
+void ExternalMetrics::RecordCrashUI(const std::string &action_string) {
+  if (g_browser_process && g_browser_process->metrics_service()) {
+    g_browser_process->metrics_service()->LogChromeOSCrash(action_string);
+  }
+}
+
+void ExternalMetrics::RecordCrash(const std::string &crash_kind) {
+  BrowserThread::PostTask(
+      BrowserThread::UI, FROM_HERE,
+      NewRunnableMethod(this, &ExternalMetrics::RecordCrashUI, crash_kind));

[petkov, 2011/01/06 18:50:36]

You probably want to stay on the file thread -- not sure...

[kmixter1, 2011/01/14 00:07:02]

I'm not sure either.  Will defer to an owner of this code as UI thread is where
all other processing happens in metrics_service and this routine doesn't block.

[jar (doing other things), 2011/01/18 22:32:23]

I believe jumping over to the UI thread is both correct and critical.  Without
this PostTask, values will be read (for upload) on the UI thread, and altered
here (on another thread?).


On 2011/01/14 00:07:02, kmixter1 wrote:

+}
+
 void ExternalMetrics::RecordHistogram(const char* histogram_data) {
   int sample, min, max, nbuckets;
   char name[128];   // length must be consistent with sscanf format below.
   int n = sscanf(histogram_data, "%127s %d %d %d %d",
                  name, &sample, &min, &max, &nbuckets);
   if (n != 5) {
     LOG(ERROR) << "bad histogram request: " << histogram_data;
     return;
   }
   // Do not use the UMA_HISTOGRAM_... macros here.  They cache the Histogram
@@ skipping 100 matching lines @@
       char* name = reinterpret_cast<char*>(buffer);
       char* value = reinterpret_cast<char*>(p + 1);
       if (test_recorder_ != NULL) {
         test_recorder_(name, value);
       } else if (strcmp(name, "histogram") == 0) {
         RecordHistogram(value);
       } else if (strcmp(name, "linearhistogram") == 0) {
         RecordLinearHistogram(value);
       } else if (strcmp(name, "useraction") == 0) {
         RecordAction(value);
+      } else if (strcmp(name, "crash") == 0) {

[petkov, 2011/01/06 18:50:36]

keep the ifs sorted?

[kmixter1, 2011/01/14 00:07:02]

Done.

+        RecordCrash(value);
       } else {
         LOG(ERROR) << "invalid event type: " << name;
       }
     }
   }
 
   result = ftruncate(fd, 0);
   if (result < 0) {
     PLOG(ERROR) << "truncate metrics log";
   }
@@ skipping 17 matching lines @@
 void ExternalMetrics::ScheduleCollector() {
   bool result;
   result = BrowserThread::PostDelayedTask(
     BrowserThread::FILE, FROM_HERE, NewRunnableMethod(
         this, &chromeos::ExternalMetrics::CollectEventsAndReschedule),
     kExternalMetricsCollectionIntervalMs);
   DCHECK(result);
 }
 
 }  // namespace chromeos