Issue 6077006: Fix cast errors in unicode.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6077006: Fix cast errors in unicode.cc (Closed)

Created:
10 years ago by ry

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Erik Corry, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Fix cast errors in unicode.cc

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+151 lines, -150 lines)			Patch
	M	src/unicode.cc	View		16 chunks	+151 lines, -150 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

There are a bunch of -1's in unicode.cc that should be static_cast to uchar - ...

10 years ago (2010-12-22 20:03:26 UTC) #1

Mads Ager (chromium)

Thanks for the patch. This file is auto generated. Lasse, would it be easy to ...

9 years, 11 months ago (2011-01-03 08:27:38 UTC) #2

Lasse Reichstein

9 years, 11 months ago (2011-01-03 11:44:22 UTC) #4

I've implemented the change in the generator used to create unicode.cc, and
committed a new version in revision 6133 (Changelist:
http://codereview.chromium.org/5993006/).
I'll close this issue.

Expand Messages | Collapse Messages