Refactored app cache clear on exit code to happen in the object owning the files.

chrome/browser/appcache/chrome_appcache_service.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_APPCACHE_CHROME_APPCACHE_SERVICE_H_
 #define CHROME_BROWSER_APPCACHE_CHROME_APPCACHE_SERVICE_H_
 #pragma once
 
 #include "base/ref_counted.h"
 #include "chrome/browser/browser_thread.h"
@@ skipping 17 matching lines @@
     : public base::RefCountedThreadSafe<ChromeAppCacheService,
                                         BrowserThread::DeleteOnIOThread>,
       public appcache::AppCacheService,
       public appcache::AppCachePolicy,
       public NotificationObserver {
  public:
   ChromeAppCacheService();
 
   void InitializeOnIOThread(
       const FilePath& profile_path, bool is_incognito,
-      scoped_refptr<HostContentSettingsMap> content_settings_map);
+      scoped_refptr<HostContentSettingsMap> content_settings_map,
+      bool clear_local_state_on_exit);
 
   // Helpers used by the extension service to grant and revoke
   // unlimited storage to app extensions.
   void SetOriginQuotaInMemory(const GURL& origin, int64 quota);
   void ResetOriginQuotaInMemory(const GURL& origin);
 
-  static void ClearLocalState(const FilePath& profile_path);
+  void SetClearLocalStateOnExit(bool clear_local_state) {
+    clear_local_state_on_exit_ = clear_local_state;
+  }
 
  private:
   friend class BrowserThread;
   friend class DeleteTask<ChromeAppCacheService>;
 
   virtual ~ChromeAppCacheService();
 
   // AppCachePolicy overrides
   virtual bool CanLoadAppCache(const GURL& manifest_url);
   virtual int CanCreateAppCache(const GURL& manifest_url,
                                 net::CompletionCallback* callback);
 
   // NotificationObserver override
   virtual void Observe(NotificationType type,
                        const NotificationSource& source,
                        const NotificationDetails& details);
 
   scoped_refptr<HostContentSettingsMap> host_contents_settings_map_;
   NotificationRegistrar registrar_;
+  bool clear_local_state_on_exit_;

[jochen (gone - plz use gerrit), 2011/01/04 14:32:53]

this is accessed on both IO and UI threads, so you'll need a lock

+  FilePath cache_path_;
 };
 
 #endif  // CHROME_BROWSER_APPCACHE_CHROME_APPCACHE_SERVICE_H_