Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9471)

Unified Diff: chrome/browser/web_resource/web_resource_service.cc

Issue 6077001: Merge 68872 - Fix sync in Chromium-os by not allowing CanShowPromo to initial... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/597/src/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_resource/web_resource_service.cc
===================================================================
--- chrome/browser/web_resource/web_resource_service.cc (revision 69725)
+++ chrome/browser/web_resource/web_resource_service.cc (working copy)
@@ -518,10 +518,14 @@
}
}
+ // Note that HasProfileSyncService() will be false for ChromeOS, so
+ // promo_options will only be true if the user has an extension installed.
+ // See http://crosbug/10209
bool promo_options =
- sync_ui_util::GetStatus(
- profile->GetProfileSyncService()) == sync_ui_util::SYNCED ||
- has_extensions;
+ (profile->HasProfileSyncService() &&
+ sync_ui_util::GetStatus(
+ profile->GetProfileSyncService()) == sync_ui_util::SYNCED) ||
+ has_extensions;
return !promo_closed &&
promo_options &&
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698