Issue 6075005: Change scanner buffers to not use utf-8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6075005: Change scanner buffers to not use utf-8. (Closed)

Created:
10 years ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Visibility:
Public.

Change scanner buffers to not use utf-8. Make preparser keep its symbol text itself instead of relying on the scanner. Committed: http://code.google.com/p/v8/source/detail?r=6115

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+520 lines, -205 lines)			Patch
M	src/factory.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/factory.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/globals.h	View		2 chunks	+9 lines, -4 lines	0 comments	Download
M	src/heap.h	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/heap.cc	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download
M	src/heap-inl.h	View	1	1 chunk	+65 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/objects.cc	View		3 chunks	+112 lines, -0 lines	0 comments	Download
M	src/parser.h	View		2 chunks	+22 lines, -4 lines	0 comments	Download
M	src/parser.cc	View		14 chunks	+40 lines, -35 lines	0 comments	Download
M	src/preparse-data.h	View		5 chunks	+37 lines, -11 lines	0 comments	Download
M	src/preparse-data.cc	View		1 chunk	+12 lines, -9 lines	0 comments	Download
M	src/preparser.cc	View		3 chunks	+16 lines, -15 lines	0 comments	Download
M	src/scanner.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	src/scanner.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/scanner-base.h	View	1	8 chunks	+122 lines, -92 lines	0 comments	Download
M	src/scanner-base.cc	View		7 chunks	+6 lines, -28 lines	0 comments	Download
M	src/utils.h	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Lasse Reichstein

Many of the changes should be trivial, just to support pure ASCII/UC16 all the way ...

10 years ago (2010-12-22 16:00:30 UTC) #1

LGTM