Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2561)

Unified Diff: base/values.h

Issue 6074003: Handle policy refresh internally in ConfigurationPolicyPrefStore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix nit Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/values.cc » ('j') | chrome/browser/policy/configuration_policy_pref_store.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/values.h
diff --git a/base/values.h b/base/values.h
index 68b8f0038fcb2cf4371e5d17abfc6cb94c24d671..2719d272b35c38eccdc9562e1fde1905ee2041df 100644
--- a/base/values.h
+++ b/base/values.h
@@ -308,16 +308,6 @@ class DictionaryValue : public Value {
// replaced.
void MergeDictionary(const DictionaryValue* dictionary);
- // Builds a vector containing all of the paths that are different between
- // the dictionary and a second specified dictionary. These are paths of
- // values that are either in one dictionary or the other but not both, OR
- // paths that are present in both dictionaries but differ in value.
- // Path strings are in ascending lexicographical order in the generated
- // vector. |different_paths| is cleared before added any paths.
- void GetDifferingPaths(
- const DictionaryValue* other,
- std::vector<std::string>* different_paths) const;
-
// This class provides an iterator for the keys in the dictionary.
// It can't be used to modify the dictionary.
//
@@ -344,17 +334,6 @@ class DictionaryValue : public Value {
key_iterator end_keys() const { return key_iterator(dictionary_.end()); }
private:
- // Does the actual heavy lifting for GetDifferingPaths.
- // Returns true if a path is added to different_paths, otherwise false.
- // The difference compuation is calculated recursively. The keys for
- // dictionaries that are handled by recursive calls more shallow than
- // the current one are concatenated and passed through to deeper calls in
- // |path_prefix|.
- bool GetDifferingPathsHelper(
- const std::string& path_prefix,
- const DictionaryValue* other,
- std::vector<std::string>* different_paths) const;
-
ValueMap dictionary_;
DISALLOW_COPY_AND_ASSIGN(DictionaryValue);
« no previous file with comments | « no previous file | base/values.cc » ('j') | chrome/browser/policy/configuration_policy_pref_store.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698