Issue 6073001: Don't replace gold with default ld - we don't need it since... ages ago....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6073001: Don't replace gold with default ld - we don't need it since... ages ago.... (Closed)

Created:
10 years ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/valgrind/

Visibility:
Public.

Description

Don't replace gold with default ld - we don't need it since... ages ago. TBR=glider TEST=built memcheck and TSan with gold locally, tested on ls Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69714

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -26 lines)			Patch
	M	scripts/common.sh	View		1 chunk	+0 lines, -26 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years ago (2010-12-24 06:50:58 UTC) #2

LGTM

On Mon, Dec 20, 2010 at 7:10 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Don't replace gold with default ld - we don't need it since... ages ago.
> TBR=glider
> TEST=built memcheck and TSan with gold locally, tested on ls
>
> Please review this at http://codereview.chromium.org/6073001/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/deps/third_party/valgrind/
>
> Affected files:
>  M     scripts/common.sh
>
>
> Index: scripts/common.sh
> ===================================================================
> --- scripts/common.sh   (revision 69705)
> +++ scripts/common.sh   (working copy)
> @@ -108,32 +108,6 @@
>     chmod +x install-sh
>   fi
>
> -  # If gold is installed as a linker, use the old one
> -  OVERRIDE_LD_DIR="${THISDIR}/override_ld"
> -  if ld --version | grep gold
> -  then
> -    # build/install-build-deps leaves original ld around, try using that
> -    if test -x /usr/bin/ld.orig
> -    then
> -      echo "Using /usr/bin/ld.orig instead of gold to link valgrind"
> -      test -d "${OVERRIDE_LD_DIR}" && rm -rf "${OVERRIDE_LD_DIR}"
> -      mkdir "${OVERRIDE_LD_DIR}"
> -      ln -s /usr/bin/ld.orig "${OVERRIDE_LD_DIR}/ld"
> -      PATH="${OVERRIDE_LD_DIR}:${PATH}"
> -    # Ubuntu diverts original ld to ld.single when it installs
> binutils-gold
> -    elif test -x /usr/bin/ld.single
> -    then
> -      echo "Using /usr/bin/ld.single instead of gold to link valgrind"
> -      test -d "${OVERRIDE_LD_DIR}" && rm -rf "${OVERRIDE_LD_DIR}"
> -      mkdir "${OVERRIDE_LD_DIR}"
> -      ln -s /usr/bin/ld.single "${OVERRIDE_LD_DIR}/ld"
> -      PATH="${OVERRIDE_LD_DIR}:${PATH}"
> -    else
> -      echo "Cannot build valgrind with gold.  Please switch to normal
> /usr/bin/ld, rerun this script, then switch back to gold."
> -      exit 1
> -    fi
> -  fi
> -
>   ./configure $CONFIGURE_FLAGS --prefix="${OUTPUT_DIR}"
>   make -j4
>
>
>
>

Expand Messages | Collapse Messages