Issue 6072008: verity: extract the compare part out of compute_and_compare

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6072008: verity: extract the compare part out of compute_and_compare (Closed)

Created:
10 years ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
Will Drewry

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/dm-verity.git@master

Visibility:
Public.

Description

verity: extract the compare part out of compute_and_compare BUG=9752 TEST=Unit tests pass. Booted and surfed a few sites. Change-Id: I5d1f63b7afa2e6f316defd1997a9f1d3934144f6 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=58741d1

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix per review. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -27 lines)			Patch
	M	dm-bht.c	View	1	7 chunks	+15 lines, -27 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Will Drewry

LGTM after fixing the nits. Thanks! http://codereview.chromium.org/6072008/diff/1/dm-bht.c File dm-bht.c (right): http://codereview.chromium.org/6072008/diff/1/dm-bht.c#newcode96 dm-bht.c:96: * dm_bht_compute_and_compare: hashes ...

9 years, 11 months ago (2011-01-11 21:38:45 UTC) #4

Mandeep Singh Baines

9 years, 11 months ago (2011-01-11 22:22:44 UTC) #5

Fixed. And committed.

wad@chromium.org (wad@chromium.org) wrote:
> LGTM after fixing the nits.
> 
> Thanks!
> 
> 
> http://codereview.chromium.org/6072008/diff/1/dm-bht.c
> File dm-bht.c (right):
> 
> http://codereview.chromium.org/6072008/diff/1/dm-bht.c#newcode96
> dm-bht.c:96: * dm_bht_compute_and_compare: hashes a page of data;
> compares it to a hash
> please update the comment
> 

D'oh. Fixed.

> http://codereview.chromium.org/6072008/diff/1/dm-bht.c#newcode757
> dm-bht.c:757: if (dm_bht_compute_hash(bht, hash_desc,	page, digest) ||
> is there a tab hiding before page or is it a rietveld weirdness?
> 

Yep. There was a tab. Fixed.

> http://codereview.chromium.org/6072008/

Expand Messages | Collapse Messages