commit_queue.py - Issue 6072006: Enforce workdir presence and add a README file in it to explain what needs to be done.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: commit_queue.py

Issue 6072006: Enforce workdir presence and add a README file in it to explain what needs to be done. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/commit-queue

Patch Set: Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: commit_queue.py

diff --git a/commit_queue.py b/commit_queue.py

index 2166e20c5138e57bf0364a9d7366889a1835a008..853a2a9d865d507d6f408aadce74e21b21bb922b 100755

--- a/commit_queue.py

+++ b/commit_queue.py

@@ -72,10 +72,10 @@ def main():

level=level,

format='%(asctime)s %(levelname)7s %(message)s')

root_dir = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'workdir')

- if not os.path.isdir(root_dir):

- os.makedirs(root_dir)

- gaia_creds = creds.Credentials(os.path.join(root_dir, '.gaia_pwd'))

+ gaia_file = os.path.join(root_dir, '.gaia_pwd')

+ if not os.path.isfile(gaia_file):

+ parser.error('Please read workdir/README.')

+ gaia_creds = creds.Credentials(gaia_file)

rietveld_obj = rietveld.Rietveld(

'http://codereview.chromium.org',

'commit-bot@chromium.org',

« no previous file with comments | « .gitignore ('k') | workdir/README » ('j') | no next file with comments »