Issue 6071: Removed the use of Math.random() and new Date() for building...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6071: Removed the use of Math.random() and new Date() for building... (Closed)

Created:
12 years, 2 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee, Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Removed the use of Math.random() and new Date() for building the RNG pool in the crypto benchmark. Committed: http://code.google.com/p/v8/source/detail?r=404

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -10 lines)			Patch
M	benchmarks/README.txt	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	benchmarks/base.js	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
M	benchmarks/crypto.js	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	benchmarks/run.html	View		1 chunk	+14 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

looks ok to me http://codereview.chromium.org/6071/diff/1/2 File benchmarks/base.js (right): http://codereview.chromium.org/6071/diff/1/2#newcode32 Line 32: whitespace change on purpose? ...

12 years, 2 months ago (2008-10-02 07:11:35 UTC) #2

On 2008/10/02 06:26:40, Kasper Lund wrote:
> 

LGTM

Expand Messages | Collapse Messages