Issue 6070011: Refactor grit -D flags into a gyp variable so we don't

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6070011: Refactor grit -D flags into a gyp variable so we don't (Closed)

Created:
9 years, 11 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
satorux1, Evan Martin

CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Refactor grit -D flags into a gyp variable so we don't have to repeat the logic for it in a bunch of different places. I had to add another level of variables{} so I could use use_titlecase_in_grd_files in a condition. I also removed some quotes around default values since that seems to be the more common way to express boolean values. BUG=68028 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70757

Patch Set 1 #

Patch Set 2 : works #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -105 lines)			Patch
M	app/app.gyp	View	1	2 chunks	+4 lines, -15 lines	0 comments	Download
M	build/common.gypi	View	1	13 chunks	+47 lines, -22 lines	0 comments	Download
M	chrome/chrome.gyp	View	1	5 chunks	+8 lines, -52 lines	0 comments	Download
M	chrome/default_plugin/default_plugin.gyp	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	gfx/gfx.gyp	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	net/net.gyp	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1	3 chunks	+6 lines, -3 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gypi	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Nice refactoring!

Expand Messages | Collapse Messages