Added labelled thread names to help with some debugging activity. Right now,...

src/platform.h

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 369 matching lines @@
   // LOCAL_STORAGE_KEY_MIN_VALUE and LOCAL_STORAGE_KEY_MAX_VALUE are specified
   // to ensure that enumeration type has correct value range (see Issue 830 for
   // more details).
   enum LocalStorageKey {
     LOCAL_STORAGE_KEY_MIN_VALUE = kMinInt,
     LOCAL_STORAGE_KEY_MAX_VALUE = kMaxInt
   };
 
   // Create new thread.
   Thread();
+#ifdef DEBUG_THREAD_NAMES
+  explicit Thread(const char* name);
+#endif
   virtual ~Thread();
 
   // Start new thread by calling the Run() method in the new thread.
   void Start();
 
   // Wait until thread terminates.
   void Join();
 
+#ifdef DEBUG_THREAD_NAMES
+  inline const char* Name() const {

[Søren Thygesen Gjesse, 2011/01/03 07:48:34]

Please use all lower-case for this type of accessor, see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...

[marklam, 2011/01/04 01:47:09]

Done.

+    return name_;
+  }
+#endif
+
   // Abstract method for run handler.
   virtual void Run() = 0;
 
   // Thread-local storage.
   static LocalStorageKey CreateThreadLocalKey();
   static void DeleteThreadLocalKey(LocalStorageKey key);
   static void* GetThreadLocal(LocalStorageKey key);
   static int GetThreadLocalInt(LocalStorageKey key) {
     return static_cast<int>(reinterpret_cast<intptr_t>(GetThreadLocal(key)));
   }
   static void SetThreadLocal(LocalStorageKey key, void* value);
   static void SetThreadLocalInt(LocalStorageKey key, int value) {
     SetThreadLocal(key, reinterpret_cast<void*>(static_cast<intptr_t>(value)));
   }
   static bool HasThreadLocal(LocalStorageKey key) {
     return GetThreadLocal(key) != NULL;
   }
 
   // A hint to the scheduler to let another thread run.
   static void YieldCPU();
 
  private:
+#ifdef DEBUG_THREAD_NAMES
+  void SetName(const char *name);

[Søren Thygesen Gjesse, 2011/01/03 07:48:34]

This setter should be called set_name, see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...

[marklam, 2011/01/04 01:47:09]

Done.

+#endif
+
   class PlatformData;
   PlatformData* data_;
+#ifdef DEBUG_THREAD_NAMES
+  char name_[16];

[Søren Thygesen Gjesse, 2011/01/03 07:48:34]

I think that this constant deserves a comment. E.g. "The thread name length
limit on Linux is 16.". Actually you should also make a constant for it

static const int kMaxThreadNamelength = 16;

[marklam, 2011/01/04 01:47:09]

Done.

+#endif
+
   DISALLOW_COPY_AND_ASSIGN(Thread);
 };
 
 
 // ----------------------------------------------------------------------------
 // Mutex
 //
 // Mutexes are used for serializing access to non-reentrant sections of code.
 // The implementations of mutex should allow for nested/recursive locking.
 
@@ skipping 179 matching lines @@
   PlatformData* data_;  // Platform specific data.
   int samples_taken_;  // Counts stack samples taken.
   DISALLOW_IMPLICIT_CONSTRUCTORS(Sampler);
 };
 
 #endif  // ENABLE_LOGGING_AND_PROFILING
 
 } }  // namespace v8::internal
 
 #endif  // V8_PLATFORM_H_