Added labelled thread names to help with some debugging activity. Right now,...

src/platform-freebsd.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 393 matching lines @@
   return pthread_equal(data_->thread_, pthread_self());
 }
 
 
 bool ThreadHandle::IsValid() const {
   return data_->thread_ != kNoThread;
 }
 
 
 Thread::Thread() : ThreadHandle(ThreadHandle::INVALID) {
+#ifdef DEBUG_THREAD_NAMES
+  SetName("v8:<unknown>");
+#endif
 }
 
 
+#ifdef DEBUG_THREAD_NAMES
+Thread::Thread(const char* name) : ThreadHandle(ThreadHandle::INVALID) {
+  SetName(name);
+}
+#endif
+
+
 Thread::~Thread() {
 }
 
 
 static void* ThreadEntry(void* arg) {
   Thread* thread = reinterpret_cast<Thread*>(arg);
   // This is also initialized by the first argument to pthread_create() but we
   // don't know which thread will run first (the original thread or the new
   // one) so we initialize it here too.
   thread->thread_handle_data()->thread_ = pthread_self();
   ASSERT(thread->IsValid());
   thread->Run();
   return NULL;
 }
 
 
+#ifdef DEBUG_THREAD_NAMES
+void Thread::SetName(const char* name) {
+  strncpy(name_, name, sizeof(name_));
+  name_[sizeof(name_)-1] = '\0';

[Søren Thygesen Gjesse, 2011/01/03 07:48:34]

Please add spaces on both sides of '-'. In all the other platform files as well.

[marklam, 2011/01/04 01:47:09]

Done.

+}
+#endif
+
+
 void Thread::Start() {
   pthread_create(&thread_handle_data()->thread_, NULL, ThreadEntry, this);
   ASSERT(IsValid());
 }
 
 
 void Thread::Join() {
   pthread_join(thread_handle_data()->thread_, NULL);
 }
 
@@ skipping 224 matching lines @@
   }
 
   // This sampler is no longer the active sampler.
   active_sampler_ = NULL;
   active_ = false;
 }
 
 #endif  // ENABLE_LOGGING_AND_PROFILING
 
 } }  // namespace v8::internal