Added labelled thread names to help with some debugging activity. Right now,...

SConstruct

 # Copyright 2010 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 106 matching lines @@
       'CPPDEFINES':   ['OBJECT_PRINT'],
     },
     'protectheap:on': {
       'CPPDEFINES':   ['ENABLE_VMSTATE_TRACKING', 'ENABLE_HEAP_PROTECTION'],
     },
     'profilingsupport:on': {
       'CPPDEFINES':   ['ENABLE_VMSTATE_TRACKING', 'ENABLE_LOGGING_AND_PROFILING'],
     },
     'debuggersupport:on': {
       'CPPDEFINES':   ['ENABLE_DEBUGGER_SUPPORT'],
+    },
+    'debugthreadnames:on': {
+      'CPPDEFINES':   ['DEBUG_THREAD_NAMES'],

[Søren Thygesen Gjesse, 2011/01/03 07:48:34]

Why do you want to enable/disable this using conditional compilation? It does
not seem to add any overhead except for the 16 char name for each thread. If
there are other penalties then I suggest that a flag --threadnames is added to
skip the OS call to actually set the name for the thread.

[marklam, 2011/01/04 01:47:09]

I didn't know how strict we want to be about not incurring any cost that may not
yield any benefits for the various platforms.  I agree that the cost here is
minimal, and I'm fine with removing the conditional nature of it.  I'll make the
appropriate change for making this unconditional.  Thanks.

     }
   },
   'gcc': {
     'all': {
       'CCFLAGS':      ['$DIALECTFLAGS', '$WARNINGFLAGS'],
       'CXXFLAGS':     ['$CCFLAGS', '-fno-rtti', '-fno-exceptions'],
     },
     'visibility:hidden': {
       # Use visibility=default to disable this.
       'CXXFLAGS':     ['-fvisibility=hidden']
@@ skipping 590 matching lines @@
   'profilingsupport': {
     'values': ['on', 'off'],
     'default': 'on',
     'help': 'enable profiling of JavaScript code'
   },
   'debuggersupport': {
     'values': ['on', 'off'],
     'default': 'on',
     'help': 'enable debugging of JavaScript code'
   },
+  'debugthreadnames': {
+    'values': ['on', 'off'],
+    'default': 'off',
+    'help': 'enable labelled thread names for debugging'
+  },
   'soname': {
     'values': ['on', 'off'],
     'default': 'off',
     'help': 'turn on setting soname for Linux shared library'
   },
   'msvcrt': {
     'values': ['static', 'shared'],
     'default': 'static',
     'help': 'the type of Microsoft Visual C++ runtime library to use'
   },
@@ skipping 409 matching lines @@
 # version of scons.  Also, there's a bug in some revisions that
 # doesn't allow this flag to be set, so we swallow any exceptions.
 # Lovely.
 try:
   SetOption('warn', 'no-deprecated')
 except:
   pass
 
 
 Build()