Issue 6069012: Add constraints verification to LAllocator::MarkAsCall().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6069012: Add constraints verification to LAllocator::MarkAsCall(). (Closed)

Created:
9 years, 11 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add constraints verification to LAllocator::MarkAsCall(). Committed: http://code.google.com/p/v8/source/detail?r=6149

Patch Set 1 #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
	M	src/ia32/lithium-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/lithium-allocator.cc	View		1 chunk	+19 lines, -1 line	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

9 years, 11 months ago (2011-01-04 11:21:23 UTC) #2

LGTM with small comments below.

http://codereview.chromium.org/6069012/diff/1/src/lithium-allocator.cc
File src/lithium-allocator.cc (right):

http://codereview.chromium.org/6069012/diff/1/src/lithium-allocator.cc#newcod...
src/lithium-allocator.cc:1596:
LUnallocated::cast(summary->Output())->HasFixedPolicy() ||
You could define a predicate on LUnallocated:

bool HasFlexibleRegisterPolicy() {
  return HasRegisterPolicy() && !HasFixedPolicy();
}

And use it (negated) in three places here.

http://codereview.chromium.org/6069012/diff/1/src/lithium-allocator.cc#newcod...
src/lithium-allocator.cc:1599:
ASSERT(LUnallocated::cast(summary->InputAt(i))->HasFixedPolicy() ||
I'd prefer to have the for loops wrapped in #ifdef DEBUG so there's clearly no
code in release builds.

Expand Messages | Collapse Messages