Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 6069004: Use FilePath::BaseName instead of the deprecated file_util::GetFilenameFromPath. Part 3. (Closed)

Created:
10 years ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, evanm
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Use FilePath::BaseName instead of the deprecated file_util::GetFilenameFromPath. Part 3. BUG=24672 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70159

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/test/mini_installer_test/chrome_mini_installer.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/mini_installer_test/mini_installer_test_util.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
Please, take a look.
10 years ago (2010-12-24 13:48:58 UTC) #1
evanm
10 years ago (2010-12-24 14:14:07 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698