views: Fix shifted keyevents in textfield.

views: Fix shifted keyevents in textfield.

Pressing 0-9 in a textfield with caps lock turned on would generate shifted
keyevents, which it shouldn't. So distinguish between caps-lock and shift.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70452

[oshima, 2011-01-04 19:08:07]

thank you for the patch. can you add test?

[sadrul, 2011-01-04 19:33:15]

On 2011/01/04 19:08:07, oshima wrote:
> thank you for the patch. can you add test?

Added the tests in existing KeyTest, instead of creating a new test for
caps-locked key events. I can split them out into a new test if you think that
would be better.

[oshima, 2011-01-04 20:23:41]

please remove default argument? then LGTM

http://codereview.chromium.org/6068005/diff/3001/views/controls/textfield/nat...
File views/controls/textfield/native_textfield_views_unittest.cc (right):

http://codereview.chromium.org/6068005/diff/3001/views/controls/textfield/nat...
views/controls/textfield/native_textfield_views_unittest.cc:77: bool capslock =
false) {
default argument is not allowed by style guide.

[sadrul, 2011-01-04 20:29:27]

Thanks for the quick reviews!

http://codereview.chromium.org/6068005/diff/3001/views/controls/textfield/nat...
File views/controls/textfield/native_textfield_views_unittest.cc (right):

http://codereview.chromium.org/6068005/diff/3001/views/controls/textfield/nat...
views/controls/textfield/native_textfield_views_unittest.cc:77: bool capslock =
false) {
On 2011/01/04 20:23:41, oshima wrote:
> default argument is not allowed by style guide.

Ah, noted. Fixed.

[oshima, 2011-01-04 21:47:50]

lgtm