chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc - Issue 6066011: Add a checkbox to the malware interstitial page, for user to opt-in to send m...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

Issue 6066011: Add a checkbox to the malware interstitial page, for user to opt-in to send m... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_blocking_page.cc ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

===================================================================

--- chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc (revision 70746)

+++ chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc (working copy)

@@ -297,19 +297,17 @@

IN_PROC_BROWSER_TEST_F(SafeBrowsingBlockingPageTest,

MalwareIframeReportDetails) {

- // Enable reporting of malware details.

- browser()->GetProfile()->GetPrefs()->SetBoolean(

- prefs::kSafeBrowsingReportingEnabled, true);

- EXPECT_TRUE(browser()->GetProfile()->GetPrefs()->GetBoolean(

- prefs::kSafeBrowsingReportingEnabled));

GURL url = test_server()->GetURL(kMalwarePage);

GURL iframe_url = test_server()->GetURL(kMalwareIframe);

AddURLResult(iframe_url, SafeBrowsingService::URL_MALWARE);

ui_test_utils::NavigateToURL(browser(), url);

- SendCommand("\"proceed\""); // Simulate the user clicking "back"

+ SendCommand("\"doReport\""); // Simulate the user checking the checkbox.

+ EXPECT_TRUE(browser()->GetProfile()->GetPrefs()->GetBoolean(

+ prefs::kSafeBrowsingReportingEnabled));

+ SendCommand("\"proceed\""); // Simulate the user clicking "back"

AssertNoInterstitial(); // Assert the interstitial is gone

EXPECT_EQ(url, browser()->GetSelectedTabContents()->GetURL());