Add a checkbox to the malware interstitial page, for user to opt-in to send m...

chrome/browser/resources/safe_browsing_malware_block.html

Index: chrome/browser/resources/safe_browsing_malware_block.html
===================================================================
--- chrome/browser/resources/safe_browsing_malware_block.html	(revision 70457)
+++ chrome/browser/resources/safe_browsing_malware_block.html	(working copy)
@@ -114,6 +114,15 @@
     window.domAutomationController.setAutomationId(1);
     window.domAutomationController.send(cmd);
   }
+
+  function savepreference() {

[arv (Not doing code reviews), 2011/01/05 21:33:14]

savePreference

[panayiotis, 2011/01/05 23:00:05]

Done.

+    var checkBox = document.getElementById('checkreport');
+    if (checkBox.checked) {
+      sendCommand('doReport');
+    } else {
+      sendCommand('dontReport');
+    }
+  }
 </script>
 
 </head>
@@ -137,6 +146,13 @@
 
       <div class="main" i18n-values=".innerHTML:description3"></div>
 
+      <div class="main" jsdisplay="displaycheckbox">
+        <hr>
+        <form class="submission">
+          <input name="checked" id="checkreport" type="checkbox" jsvalues=".checked:boxchecked" onclick="savepreference()">&nbsp;<label for="checkreport" i18n-content="confirm_text"></label>

[arv (Not doing code reviews), 2011/01/05 21:33:14]

Long line

[arv (Not doing code reviews), 2011/01/05 21:33:14]

Can you use a margin instead of the  

[arv (Not doing code reviews), 2011/01/05 21:33:14]

The label should go around the input

<label><input>Text</label>

otherwise the user cannot click on the label to check the checkbox.

[panayiotis, 2011/01/05 23:00:05]

Done.

[panayiotis, 2011/01/05 23:00:05]

Done.

[panayiotis, 2011/01/05 23:00:05]

Done.

+        </form>
+      </div>
+
     </div>
   </td>
 </table>