Issue 6066002: Initialize bug_report_ to NULL so as make sure invalid pointer is not freed....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6066002: Initialize bug_report_ to NULL so as make sure invalid pointer is not freed.... (Closed)

Created:
10 years ago by inferno

Modified:
9 years, 7 months ago

Reviewers:
rkc, jschuh, Ben Goodger (Google)

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Initialize bug_report_ to NULL so as make sure invalid pointer is not freed. BUG=67393 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69721

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/dom_ui/bug_report_ui.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

rkc

10 years ago (2010-12-20 21:48:35 UTC) #4

On 2010/12/20 17:31:34, Justin Schuh wrote:
> Should probably have unit test. Otherwise, LGTM.

LGTM