Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 6065014: Fix an bug in deoptimization after polymorphic calls in effect contexts. (Closed)

Created:
9 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix an bug in deoptimization after polymorphic calls in effect contexts. For polymorphic calls (also loads and stores) we construct a type switch graph that has a basic block merging all the variants. There is an environment simulation before the goto at the end of all the predecessor blocks. This simulation is used to define the environment on entry to the successor block, and captures the return value of the call. In effect contexts, this value should not be present in the environment. The fix is to use the AST context to decide whether to have this value in the join node's environment at all. BUG=1014 Committed: http://code.google.com/p/v8/source/detail?r=6189

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M src/hydrogen.cc View 6 chunks +28 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
There was no bug for stores, because we used an internal AssignmentId that corresponds to ...
9 years, 11 months ago (2011-01-05 15:44:59 UTC) #1
Mads Ager (chromium)
9 years, 11 months ago (2011-01-05 15:58:12 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698