Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 6065011: enter_chroot: copy over ssh configuration (Closed)

Created:
9 years, 11 months ago by zbehan
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

enter_chroot: copy over ssh configuration TEST=clean (first) enter_chroot.sh; repo sync The developer instructions for setting up chroot include steps to set up ~/.ssh/config to correctly set up ports and options. And while several attempts are made in enter_chroot to forward ssh-agent and ssh authentication to chroot as well, the ssh config stays outside of chroot, which prevents all attempts to contact the git servers if rw URL is used. This makes a copy of config on entering the chroot, allowing people to use repo from within the chroot. That is not bulletproof and does not reflect changes of config while inside the chroot, but that should be a borderline case. Change-Id: I1fcbf00c413c7af8ef14fc1e846192ac95de106d BUG=n0ne Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7580571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M enter_chroot.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zbehan
9 years, 11 months ago (2011-01-04 00:08:21 UTC) #1
diandersAtChromium
LGTM, but please get anush or sosa to OK before committing.
9 years, 11 months ago (2011-01-04 21:20:13 UTC) #2
anush
LGTM On Tue, Jan 4, 2011 at 1:20 PM, <dianders@chromium.org> wrote: > LGTM, but please ...
9 years, 11 months ago (2011-01-04 21:21:45 UTC) #3
zbehan
9 years, 11 months ago (2011-01-04 23:57:15 UTC) #4

          

Powered by Google App Engine
This is Rietveld 408576698