Issue 6065010: Remember required register kind when creating artificial virtual register.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6065010: Remember required register kind when creating artificial virtual register. (Closed)

Created:
9 years, 11 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Remember required register kind when creating artificial virtual register. Committed: http://code.google.com/p/v8/source/detail?r=6138

Patch Set 1 #

Total comments: 4

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -5 lines)			Patch
M	src/data-flow.h	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/lithium-allocator.h	View	3 chunks	+37 lines, -0 lines	4 comments	Download
M	src/lithium-allocator.cc	View	4 chunks	+16 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

9 years, 11 months ago (2011-01-03 16:44:46 UTC) #2

LGTM.  Small comments below.

http://codereview.chromium.org/6065010/diff/1/src/lithium-allocator.h
File src/lithium-allocator.h (right):

http://codereview.chromium.org/6065010/diff/1/src/lithium-allocator.h#newcode758
src/lithium-allocator.h:758: class FlexibleBitVector BASE_EMBEDDED {
Maybe GrowableBitVector is more descriptive?  It never shrinks, does it?

http://codereview.chromium.org/6065010/diff/1/src/lithium-allocator.h#newcode762
src/lithium-allocator.h:762: bool Contains(int value) const {
Maybe it's too cute, but you could make this class more specialized and have it
handle the scaling (storing first_artificial_register_ and subtracting it in the
Contains and Add functions).

http://codereview.chromium.org/6065010/diff/1/src/lithium-allocator.h#newcode773
src/lithium-allocator.h:773: static const int kInitialLength = 1024;
This seems like a big initial length.

http://codereview.chromium.org/6065010/diff/1/src/lithium-allocator.h#newcode...
src/lithium-allocator.h:1010: int first_artificial_register_;
I'd be more comfortable with an initial value, even if invalid.

Expand Messages | Collapse Messages