Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: net/url_request/url_request_unittest.cc

Issue 6065008: Do not override User-Agent header added by WebCore (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_unittest.h" 5 #include "net/url_request/url_request_unittest.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 8
9 #if defined(OS_WIN) 9 #if defined(OS_WIN)
10 #include <shlobj.h> 10 #include <shlobj.h>
(...skipping 2624 matching lines...) Expand 10 before | Expand all | Expand 10 after
2635 TestURLRequest 2635 TestURLRequest
2636 req(test_server_.GetURL("echoheaderoverride?Accept-Charset"), &d); 2636 req(test_server_.GetURL("echoheaderoverride?Accept-Charset"), &d);
2637 req.set_context(new TestURLRequestContext()); 2637 req.set_context(new TestURLRequestContext());
2638 net::HttpRequestHeaders headers; 2638 net::HttpRequestHeaders headers;
2639 headers.SetHeader(net::HttpRequestHeaders::kAcceptCharset, "koi-8r"); 2639 headers.SetHeader(net::HttpRequestHeaders::kAcceptCharset, "koi-8r");
2640 req.SetExtraRequestHeaders(headers); 2640 req.SetExtraRequestHeaders(headers);
2641 req.Start(); 2641 req.Start();
2642 MessageLoop::current()->Run(); 2642 MessageLoop::current()->Run();
2643 EXPECT_EQ(std::string("koi-8r"), d.data_received()); 2643 EXPECT_EQ(std::string("koi-8r"), d.data_received());
2644 } 2644 }
2645
2646 // Check that default User-Agent header is sent.
2647 TEST_F(URLRequestTestHTTP, DefaultUserAgent) {
2648 ASSERT_TRUE(test_server_.Start());
2649
2650 TestDelegate d;
2651 TestURLRequest req(test_server_.GetURL("echoheader?User-Agent"), &d);
2652 req.set_context(new TestURLRequestContext());
2653 req.Start();
2654 MessageLoop::current()->Run();
2655 EXPECT_EQ(req.context()->GetUserAgent(req.url()), d.data_received());
2656 }
2657
2658 // Check that if request overrides the User-Agent header,
2659 // the default is not appended.
2660 TEST_F(URLRequestTestHTTP, OverrideUserAgent) {
2661 ASSERT_TRUE(test_server_.Start());
2662
2663 TestDelegate d;
2664 TestURLRequest
2665 req(test_server_.GetURL("echoheaderoverride?User-Agent"), &d);
2666 req.set_context(new TestURLRequestContext());
2667 net::HttpRequestHeaders headers;
2668 headers.SetHeader(net::HttpRequestHeaders::kUserAgent, "Lynx (textmode)");
2669 req.SetExtraRequestHeaders(headers);
2670 req.Start();
2671 MessageLoop::current()->Run();
2672 EXPECT_EQ(std::string("Lynx (textmode)"), d.data_received());
2673 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698