Issue 6065007: Mac: Unbreak --no-gpu-sandbox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6065007: Mac: Unbreak --no-gpu-sandbox. (Closed)

Created:
10 years ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, pam+watch_chromium.org, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Mac: Unbreak --no-gpu-sandbox. This regressed when I moved CrApplication out of base. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70102

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -4 lines)			Patch
M	chrome/common/chrome_application_mac.h	View	2 chunks	+11 lines, -0 lines	1 comment	Download
M	chrome/common/chrome_application_mac.mm	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/sandbox_mac.mm	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/gpu/gpu_main.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

10 years ago (2010-12-23 21:39:22 UTC) #2

LGTM

http://codereview.chromium.org/6065007/diff/1/chrome/common/chrome_applicatio...
File chrome/common/chrome_application_mac.h (right):

http://codereview.chromium.org/6065007/diff/1/chrome/common/chrome_applicatio...
chrome/common/chrome_application_mac.h:60: }  // chrome_application_mac
Nit: this line and line 69 should be “// namespace chrome_application_mac”.

Expand Messages | Collapse Messages