Issue 6064003: Update the time formatting APIs to use string16....

Issue 6064003: Update the time formatting APIs to use string16.... (Closed)

Created:
10 years ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, idana, Raghu Simha, Paweł Hajdan Jr., ncarter (slow), pam+watch_chromium.org, tim (not reviewing), rdsmith+dwatch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, jshin+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Update the time formatting APIs to use string16. BUG=23581 TEST=everything still works Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69948

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -80 lines)			Patch
M	base/i18n/time_formatting.h	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	base/i18n/time_formatting.cc	View		2 chunks	+10 lines, -13 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_html_writer_unittest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/certificate_manager_model.cc	View	1	1 chunk	+1 line, -2 lines	1 comment	Download
M	chrome/browser/dom_ui/history2_ui.cc	View		1 chunk	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/dom_ui/history_ui.cc	View		1 chunk	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/dom_ui/options/cookies_view_handler.cc	View	1	5 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/download/download_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/certificate_viewer.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/gtk_chrome_cookie_view.cc	View	1	5 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/gtk/ssl_client_certificate_selector.cc	View	1	2 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/page_info_model.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/sync_ui_util.cc	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/cocoa/cookie_details.mm	View		5 chunks	+7 lines, -7 lines	0 comments	Download
M	net/base/net_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	printing/printed_document_posix.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/appcache/view_appcache_internals_job.cc	View	1	1 chunk	+3 lines, -5 lines	0 comments	Download
M	webkit/blob/view_blob_internals_job.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM when bots are green http://codereview.chromium.org/6064003/diff/1/webkit/appcache/view_appcache_internals_job.cc File webkit/appcache/view_appcache_internals_job.cc (right): http://codereview.chromium.org/6064003/diff/1/webkit/appcache/view_appcache_internals_job.cc#newcode117 webkit/appcache/view_appcache_internals_job.cc:117: info->creation_time)), so close to ...

10 years ago (2010-12-21 23:32:55 UTC) #2

Evan Martin

10 years ago (2010-12-22 02:45:21 UTC) #4

LGTM++, in case that wasn't obvious

http://codereview.chromium.org/6064003/diff/4002/chrome/browser/certificate_m...
File chrome/browser/certificate_manager_model.cc (right):

http://codereview.chromium.org/6064003/diff/4002/chrome/browser/certificate_m...
chrome/browser/certificate_manager_model.cc:69: rv =
base::TimeFormatShortDateNumeric(cert.valid_expiry());
curlies no longer necessary

Expand Messages | Collapse Messages