Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 6062006: Add more bailouts for Array.slice over arguments. (Closed)

Created:
9 years, 11 months ago by antonm
Modified:
9 years, 4 months ago
Reviewers:
Mads Ager (chromium), sgraham
CC:
v8-dev
Visibility:
Public.

Description

Add more bailouts for Array.slice over arguments. Unfortunately, arguments is pretty much the normal JS object. For now I am adding more sanity checks (in hope that typically arguments list is rather short.) However it probably requires more systematic treatment, for example, we could optimistically copy elements until we meet first hole and in this case resort to JS builtin. Committed: http://code.google.com/p/v8/source/detail?r=6256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -7 lines) Patch
M src/builtins.cc View 1 chunk +12 lines, -7 lines 0 comments Download
M test/mjsunit/array-slice.js View 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
Mads, may you have a look? Another option would be to revert r6085. I'll send ...
9 years, 11 months ago (2010-12-31 11:26:52 UTC) #1
Mads Ager (chromium)
9 years, 11 months ago (2011-01-04 09:06:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698