Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 6061011: Make sure we don't trigger the incompatibility badge when the flag.... (Closed)

Created:
9 years, 11 months ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
huanr
CC:
chromium-reviews
Visibility:
Public.

Description

Make sure we don't trigger the incompatibility badge if the flag is turned off when the user navigates to about:conflicts and finds a conflict. Also, record an event when we show the incompatibilities badge to the user so we can find out how often this occurs in the field. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70751

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -11 lines) Patch
M chrome/browser/enumerate_modules_model_win.cc View 1 1 chunk +20 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
9 years, 11 months ago (2011-01-07 15:35:35 UTC) #1
huanr
9 years, 11 months ago (2011-01-07 18:11:39 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698