Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Side by Side Diff: src/macros.py

Issue 6061008: Avoid double checking for IS_NUMBER by calling NonNumToNum instead of ToNumbe... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/math.js » ('j') | src/math.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2006-2009 the V8 project authors. All rights reserved. 1 # Copyright 2006-2009 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 macro IS_SPEC_OBJECT(arg) = (%_IsSpecObject(arg)); 119 macro IS_SPEC_OBJECT(arg) = (%_IsSpecObject(arg));
120 120
121 # Inline macros. Use %IS_VAR to make sure arg is evaluated only once. 121 # Inline macros. Use %IS_VAR to make sure arg is evaluated only once.
122 macro NUMBER_IS_NAN(arg) = (!%_IsSmi(%IS_VAR(arg)) && !(arg == arg)); 122 macro NUMBER_IS_NAN(arg) = (!%_IsSmi(%IS_VAR(arg)) && !(arg == arg));
123 macro NUMBER_IS_FINITE(arg) = (%_IsSmi(%IS_VAR(arg)) || arg - arg == 0); 123 macro NUMBER_IS_FINITE(arg) = (%_IsSmi(%IS_VAR(arg)) || arg - arg == 0);
124 macro TO_INTEGER(arg) = (%_IsSmi(%IS_VAR(arg)) ? arg : %NumberToInteger(ToNumber (arg))); 124 macro TO_INTEGER(arg) = (%_IsSmi(%IS_VAR(arg)) ? arg : %NumberToInteger(ToNumber (arg)));
125 macro TO_INTEGER_MAP_MINUS_ZERO(arg) = (%_IsSmi(%IS_VAR(arg)) ? arg : %NumberToI ntegerMapMinusZero(ToNumber(arg))); 125 macro TO_INTEGER_MAP_MINUS_ZERO(arg) = (%_IsSmi(%IS_VAR(arg)) ? arg : %NumberToI ntegerMapMinusZero(ToNumber(arg)));
126 macro TO_INT32(arg) = (%_IsSmi(%IS_VAR(arg)) ? arg : (arg >> 0)); 126 macro TO_INT32(arg) = (%_IsSmi(%IS_VAR(arg)) ? arg : (arg >> 0));
127 macro TO_UINT32(arg) = (arg >>> 0); 127 macro TO_UINT32(arg) = (arg >>> 0);
128 macro TO_STRING_INLINE(arg) = (IS_STRING(%IS_VAR(arg)) ? arg : NonStringToString (arg)); 128 macro TO_STRING_INLINE(arg) = (IS_STRING(%IS_VAR(arg)) ? arg : NonStringToString (arg));
129 macro TO_NUMBER_INLINE(arg) = (IS_NUMBER(%IS_VAR(arg)) ? arg : NonNumToNum(arg)) ;
129 130
130 131
131 # Macros implemented in Python. 132 # Macros implemented in Python.
132 python macro CHAR_CODE(str) = ord(str[1]); 133 python macro CHAR_CODE(str) = ord(str[1]);
133 134
134 # Constants used on an array to implement the properties of the RegExp object. 135 # Constants used on an array to implement the properties of the RegExp object.
135 const REGEXP_NUMBER_OF_CAPTURES = 0; 136 const REGEXP_NUMBER_OF_CAPTURES = 0;
136 const REGEXP_FIRST_CAPTURE = 3; 137 const REGEXP_FIRST_CAPTURE = 3;
137 138
138 # We can't put macros in macros so we use constants here. 139 # We can't put macros in macros so we use constants here.
(...skipping 29 matching lines...) Expand all
168 169
169 # PropertyDescriptor return value indices - must match 170 # PropertyDescriptor return value indices - must match
170 # PropertyDescriptorIndices in runtime.cc. 171 # PropertyDescriptorIndices in runtime.cc.
171 const IS_ACCESSOR_INDEX = 0; 172 const IS_ACCESSOR_INDEX = 0;
172 const VALUE_INDEX = 1; 173 const VALUE_INDEX = 1;
173 const GETTER_INDEX = 2; 174 const GETTER_INDEX = 2;
174 const SETTER_INDEX = 3; 175 const SETTER_INDEX = 3;
175 const WRITABLE_INDEX = 4; 176 const WRITABLE_INDEX = 4;
176 const ENUMERABLE_INDEX = 5; 177 const ENUMERABLE_INDEX = 5;
177 const CONFIGURABLE_INDEX = 6; 178 const CONFIGURABLE_INDEX = 6;
OLDNEW
« no previous file with comments | « no previous file | src/math.js » ('j') | src/math.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698