Issue 6061008: Avoid double checking for IS_NUMBER by calling NonNumToNum instead of ToNumbe...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6061008: Avoid double checking for IS_NUMBER by calling NonNumToNum instead of ToNumbe... (Closed)

Created:
9 years, 11 months ago by sandholm

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Avoid double checking for IS_NUMBER by calling NonNumToNum instead of ToNumber when the argument is known not to be a number.

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -61 lines)			Patch
M	src/macros.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/math.js	View	7 chunks	+21 lines, -21 lines	1 comment	Download
M	src/runtime.js	View	9 chunks	+37 lines, -30 lines	0 comments	Download
M	src/v8natives.js	View	4 chunks	+12 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

9 years, 11 months ago (2011-01-05 13:32:14 UTC) #2

LGTM

http://codereview.chromium.org/6061008/diff/1/src/math.js
File src/math.js (right):

http://codereview.chromium.org/6061008/diff/1/src/math.js#newcode47
src/math.js:47: if (!IS_NUMBER(x)) x = NonNumToNum(x);
Call it NonNumberToNumber.

Expand Messages | Collapse Messages