[Mac] Adds grippys to the left side of the Browser Actions container to resiz...

[Mac] Adds grippys to the left side of the Browser Actions container to resize the container (they do not work yet), refactors a bunch of code out of toolbar_controller.mm and adds a slight gradient'ed divider between the container and the page/wrench menus buttons.

http://imgur.com/OqKGF.png

TEST=none
BUG=26990
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39231

[Miranda Callahan, 2010-02-17 01:58:29]

Grippies look awesome!  Just a couple of questions...

http://codereview.chromium.org/606079/diff/3006/2005
File chrome/browser/cocoa/extensions/browser_actions_container_view.mm (right):

http://codereview.chromium.org/606079/diff/3006/2005#newcode50
chrome/browser/cocoa/extensions/browser_actions_container_view.mm:50: [[NSColor
colorWithCalibratedWhite:0.7 alpha:0.5] set];
What happens when a user installs a dark theme, like LateNight?  Will the
grippers still be visible?

http://codereview.chromium.org/606079/diff/3006/2007
File chrome/browser/cocoa/extensions/browser_actions_controller.mm (right):

http://codereview.chromium.org/606079/diff/3006/2007#newcode205
chrome/browser/cocoa/extensions/browser_actions_controller.mm:205: CGFloat
xOffset = 8.0 +
should 8.0 be a constant -- kXOffsetStart, or something?

[Avi (use Gerrit), 2010-02-17 14:45:06]

LG

[Bons, 2010-02-17 16:57:32]

Grippies actually look fine with dark backgrounds because there is a white strip
next to each black one to give it the bezeled look.

Going to wait for try-bots then commit. Thanks for the speedy reviews.

http://codereview.chromium.org/606079/diff/3006/2005
File chrome/browser/cocoa/extensions/browser_actions_container_view.mm (right):

http://codereview.chromium.org/606079/diff/3006/2005#newcode50
chrome/browser/cocoa/extensions/browser_actions_container_view.mm:50: [[NSColor
colorWithCalibratedWhite:0.7 alpha:0.5] set];
On 2010/02/17 01:58:29, Miranda Callahan wrote:
> What happens when a user installs a dark theme, like LateNight?  Will the
> grippers still be visible?
Good point. I'll test it out a bit and make sure they're good and if not then
fix it in my next change (actually making the grippy work :)

http://codereview.chromium.org/606079/diff/3006/2007
File chrome/browser/cocoa/extensions/browser_actions_controller.mm (right):

http://codereview.chromium.org/606079/diff/3006/2007#newcode205
chrome/browser/cocoa/extensions/browser_actions_controller.mm:205: CGFloat
xOffset = 8.0 +
On 2010/02/17 01:58:29, Miranda Callahan wrote:
> should 8.0 be a constant -- kXOffsetStart, or something?

Yup. Done :)

[Miranda Callahan, 2010-02-17 17:01:31]

Great!  And LGx2.