Fix construction of simple objects with setters on prototype...

Fix construction of simple objects with setters on prototype

Simple objects which are constructed without calling the actual constructor function did not take setters defined on prototype chain of the new object into account.

Constructing objects this way is now not done if there are setters involved on the prototype chain of the new object.

This only fixes the case where the setter is found when the first object from a constructor is created. If the prototype chain is changed new objects will on take any change to setters into account.

TEST=test/mjsunit/setter-on-constructor-prototype.js

Committed: http://code.google.com/p/v8/source/detail?r=3879

[Mads Ager (chromium), 2010-02-16 18:46:40]

LGTM

If it turns out to be important we could disable the optimization only if the
callback setters are for the names in the simple property assignments list.  My
guess is that it will not be worth it.

http://codereview.chromium.org/606062/diff/1/3
File src/heap.cc (right):

http://codereview.chromium.org/606062/diff/1/3#newcode2392
src/heap.cc:2392: if (FLAG_inline_new &&
move this '&&' to the next line as well.

[Søren Thygesen Gjesse, 2010-02-17 06:19:17]

http://codereview.chromium.org/606062/diff/1/3
File src/heap.cc (right):

http://codereview.chromium.org/606062/diff/1/3#newcode2392
src/heap.cc:2392: if (FLAG_inline_new &&
On 2010/02/16 18:46:40, Mads Ager wrote:
> move this '&&' to the next line as well.

Done.