Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 606061: Adds an example extension to demonstrate the processes experimental API.... (Closed)

Created:
10 years, 10 months ago by Charlie Reis
Modified:
9 years, 7 months ago
Reviewers:
rafaelw
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Adds an example extension to demonstrate the processes experimental API. The extension adds a browser action that can list all the tabs that share a renderer process with the current tab. BUG=32303 TEST=Install show_tabs as an extension. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39136

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -0 lines) Patch
A chrome/common/extensions/docs/examples/api/processes/show_tabs/icon.png View Binary file 0 comments Download
A chrome/common/extensions/docs/examples/api/processes/show_tabs/manifest.json View 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/processes/show_tabs/popup.html View 1 1 chunk +91 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Charlie Reis
Here's a demo of how the processes API can be used. (I'm looking into adding ...
10 years, 10 months ago (2010-02-16 17:14:50 UTC) #1
rafaelw
lgtm. sadly, there's no way to focus a window right now. crbug.com/31434. Looks as though ...
10 years, 10 months ago (2010-02-16 19:13:30 UTC) #2
Charlie Reis
10 years, 10 months ago (2010-02-16 19:42:10 UTC) #3
Thanks.  I put in a note about 31434 so that we can update this when it gets
fixed.

I'll go ahead and land it after lunch unless you see anything else.

http://codereview.chromium.org/606061/diff/1/2
File chrome/common/extensions/docs/examples/api/processes/show_tabs/popup.html
(right):

http://codereview.chromium.org/606061/diff/1/2#newcode13
chrome/common/extensions/docs/examples/api/processes/show_tabs/popup.html:13:
["<b>Tabs in Process ", process.id, ":</b>"].join("");
On 2010/02/16 19:13:30, rafaelw wrote:
> out of curiosity, why are you using [...].join("") construction, rather than
> just " " + " " ..."

I'd seen it in some other extensions (e.g., tabs/screenshot/screenshot.js), and
I thought I'd heard something about it being worthwhile for performance.  Turns
out that was an IE thing, and WebKit actually seems to be quicker on +.

I'll go ahead and change it, mainly because + is a bit easier to read.

Powered by Google App Engine
This is Rietveld 408576698