Fix the software renderer "soft" fullscreen mode using the wrong monitor bug.

Fix the software renderer "soft" fullscreen mode using the wrong monitor bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39107

[vangelis, 2010-02-12 18:29:21]

http://codereview.chromium.org/606005/diff/4/2001
File plugin/win/main_win.cc (right):

http://codereview.chromium.org/606005/diff/4/2001#newcode981
plugin/win/main_win.cc:981: if (GetScreenRect(GetPluginHWnd(), &screen_rect)) {
I'm not sure that this new function takes into consideration the resolution
you're requesting from the full screen mode.  For example, if you are at
1024x768, and you request to go to full screen at 640x480, wouldn't it create a
1024x768 window?

[Zhenyao Mo, 2010-02-12 20:35:24]

http://codereview.chromium.org/606005/diff/4/2001
File plugin/win/main_win.cc (right):

http://codereview.chromium.org/606005/diff/4/2001#newcode981
plugin/win/main_win.cc:981: if (GetScreenRect(GetPluginHWnd(), &screen_rect)) {
I did some further testing.

In "soft" fullscreen mode, we are fine because we won't be able to switch to
another resolution anyway.

In true fullscreen mode, even I don't call SetWindowPos at all, it seems to work
fine.  Whatever coords used in SetWindowPos is ignored.  However, I leave the
SetWindowPos here just in case the flags might be necessary.

On 2010/02/12 18:29:23, vangelis wrote:
> I'm not sure that this new function takes into consideration the resolution
> you're requesting from the full screen mode.  For example, if you are at
> 1024x768, and you request to go to full screen at 640x480, wouldn't it create
a
> 1024x768 window?

[Zhenyao Mo, 2010-02-13 01:12:49]

add the code to force software renderer to only use the "soft" fullscreen mode.

[Vangelis Kokkevis, 2010-02-13 03:06:38]

LGTM