Issue 6060005: Show invisible user on login screen if there is space after other user removal

Issue 6060005: Show invisible user on login screen if there is space after other user removal (Closed)

Created:
9 years, 12 months ago by Dmitry Polukhin

Modified:
9 years, 7 months ago

Reviewers:
whywhat, Daniel Erat

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Show invisible user on login screen if there is space after other user removal BUG=chromium-os:10056 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70255

Patch Set 2 : comments resolved #

Patch Set 3 : removed unneeded code #

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -15 lines)			Patch
	M	chrome/browser/chromeos/login/existing_user_controller.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	chrome/browser/chromeos/login/existing_user_controller.cc	View	1 2	4 chunks	+48 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

whywhat

LGTM http://codereview.chromium.org/6060005/diff/1/chrome/browser/chromeos/login/existing_user_controller.cc File chrome/browser/chromeos/login/existing_user_controller.cc (right): http://codereview.chromium.org/6060005/diff/1/chrome/browser/chromeos/login/existing_user_controller.cc#newcode141 chrome/browser/chromeos/login/existing_user_controller.cc:141: max_users = std::max(static_cast<size_t>(3), std::min(kMaxUsers, Magic constant? http://codereview.chromium.org/6060005/diff/1/chrome/browser/chromeos/login/existing_user_controller.cc#newcode142 chrome/browser/chromeos/login/existing_user_controller.cc:142: ...

9 years, 12 months ago (2010-12-27 14:28:13 UTC) #2

Dmitry Polukhin

http://codereview.chromium.org/6060005/diff/1/chrome/browser/chromeos/login/existing_user_controller.cc File chrome/browser/chromeos/login/existing_user_controller.cc (right): http://codereview.chromium.org/6060005/diff/1/chrome/browser/chromeos/login/existing_user_controller.cc#newcode141 chrome/browser/chromeos/login/existing_user_controller.cc:141: max_users = std::max(static_cast<size_t>(3), std::min(kMaxUsers, On 2010/12/27 14:28:13, whywhat wrote: ...

9 years, 12 months ago (2010-12-27 15:09:36 UTC) #3

+ Daniel

FYI

Expand Messages | Collapse Messages