Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 6060003: Disable 'create shortcut' in newtab apps pulldown menu. (Closed)

Created:
10 years ago by kochi
Modified:
9 years, 7 months ago
CC:
chromium-reviews, arv (Not doing code reviews), satorux1
Visibility:
Public.

Description

This is follow-up CL for http://codereview.chromium.org/6057002/ BUG=chromium-os:10364 TEST=manually check if pulldown menu of apps on newtab page doesn't have 'create shortcut'. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70597

Patch Set 1 #

Patch Set 2 : Fix for the review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/ntp/apps.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kochi
10 years ago (2010-12-21 06:10:09 UTC) #1
arv (Not doing code reviews)
LGTM It might have been better to use condition ? 'none' : '' instead so ...
10 years ago (2010-12-21 19:03:32 UTC) #2
kochi
Hi, Sorry for delayed response. As you suggested, changed the code to be agnostic about ...
9 years, 11 months ago (2011-01-05 08:39:49 UTC) #3
kochi
I also corrected the title and description of this CL, so the Gmail thread was ...
9 years, 11 months ago (2011-01-05 09:15:02 UTC) #4
arv (Not doing code reviews)
9 years, 11 months ago (2011-01-05 18:29:49 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698