Issue 6059006: [tabbed options] tidy up some bits of content settings

Issue 6059006: [tabbed options] tidy up some bits of content settings (Closed)

Created:
10 years ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
csilv, arv (Not doing code reviews), James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[tabbed options] tidy up some bits of content settings - fix OTR lists (we weren't getting the notifications for changed settings) - CSS improvements - move around the links BUG=64153 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69999

Patch Set 1 #

Total comments: 6

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -14 lines)			Patch
M	chrome/browser/dom_ui/options/content_settings_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/content_settings.css	View	3 chunks	+21 lines, -2 lines	5 comments	Download
M	chrome/browser/resources/options/content_settings.html	View	2 chunks	+2 lines, -6 lines	1 comment	Download
M	chrome/browser/resources/options/content_settings_exceptions_area.html	View	3 chunks	+13 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/options/options.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/shared/js/cr.js	View	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

http://codereview.chromium.org/6059006/diff/1/chrome/browser/resources/options/content_settings.css File chrome/browser/resources/options/content_settings.css (right): http://codereview.chromium.org/6059006/diff/1/chrome/browser/resources/options/content_settings.css#newcode11 chrome/browser/resources/options/content_settings.css:11: -webkit-box-flex: 1; -webkit-* should be at the top of ...

10 years ago (2010-12-22 23:37:53 UTC) #3

arv (Not doing code reviews)

LGTM with nits http://codereview.chromium.org/6059006/diff/1/chrome/browser/resources/options/content_settings.css File chrome/browser/resources/options/content_settings.css (right): http://codereview.chromium.org/6059006/diff/1/chrome/browser/resources/options/content_settings.css#newcode9 chrome/browser/resources/options/content_settings.css:9: margin-right: 4px; -webkit-margin-end http://codereview.chromium.org/6059006/diff/1/chrome/browser/resources/options/content_settings.css#newcode18 chrome/browser/resources/options/content_settings.css:18: margin-right: ...

10 years ago (2010-12-22 23:39:13 UTC) #4

Evan Stade

10 years ago (2010-12-22 23:59:19 UTC) #5

sorry, committed too early. I have another CL where I'm addressing these nits
and other RTL issues. I'll post it soon.

Expand Messages | Collapse Messages