Issue 6058005: cros: Add message for Chrome notifying WM about signout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6058005: cros: Add message for Chrome notifying WM about signout. (Closed)

Created:
10 years ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org, DaveMoore

Base URL:
ssh://git@gitrw.chromium.org:9222/cros.git@master

Visibility:
Public.

Description

cros: Add message for Chrome notifying WM about signout. Change-Id: I2cdd0179a7f498a27abb9c79eca667673df38e72 BUG=chromium-os:9915 TEST=none TBR=cmasone Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=5bcc95e

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chromeos_wm_ipc_enums.h	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

10 years ago (2010-12-22 00:51:30 UTC) #2

LGTM

On Tue, Dec 21, 2010 at 4:21 PM, <derat@chromium.org> wrote:

> Reviewers: Chris Masone,
>
> Description:
> cros: Add message for Chrome notifying WM about signout.
>
> Change-Id: I2cdd0179a7f498a27abb9c79eca667673df38e72
>
> BUG=chromium-os:9915
> TEST=none
> TBR=cmasone
>
> Please review this at http://codereview.chromium.org/6058005/
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/cros.git@master
>
> Affected files:
>  M chromeos_wm_ipc_enums.h
>
>
> Index: chromeos_wm_ipc_enums.h
> diff --git a/chromeos_wm_ipc_enums.h b/chromeos_wm_ipc_enums.h
> index
>
6de7cfa457432c423032c300c421dd03eaa81f5e..1553757f9b74af66d25547358cb22ce44dc74917
> 100644
> --- a/chromeos_wm_ipc_enums.h
> +++ b/chromeos_wm_ipc_enums.h
> @@ -260,7 +260,10 @@ enum WmIpcMessageType {
>   //   param[0]: New state, from WmIpcPowerButtonState enum.
>   WM_IPC_MESSAGE_WM_NOTIFY_POWER_BUTTON_STATE = 21,
>
> -  // NEXT VALUE TO USE: 22
> +  // Sent from Chrome to the window manager when the user is signing out.
> +  WM_IPC_MESSAGE_WM_NOTIFY_SIGNING_OUT = 22,
> +
> +  // NEXT VALUE TO USE: 23
>  };
>
>  inline const char* WmIpcMessageTypeToString(WmIpcMessageType type) {
>
>
>

Expand Messages | Collapse Messages