DOMUI Settings: UTH: Fix up the 'Web Content' section.

chrome/browser/resources/options/advanced_options.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
 var OptionsPage = options.OptionsPage;
 
   //
   // AdvancedOptions class
@@ skipping 41 matching lines @@
       $('autoOpenFileTypesResetToDefault').onclick = function(event) {
         chrome.send('autoOpenFileTypesAction');
       };
       $('fontSettingsCustomizeFontsButton').onclick = function(event) {
         OptionsPage.showPageByName('fontSettings');
         chrome.send('coreOptionsUserMetricsAction', ['Options_FontSettings']);
       };
       $('defaultZoomLevel').onchange = function(event) {
         chrome.send('defaultZoomLevelAction',
             [String(event.target.options[event.target.selectedIndex].value)]);
-      }
+      };
+      $('defaultFontSize').onchange = function(event) {
+        chrome.send('defaultFontSizeAction',
+            [String(event.target.options[event.target.selectedIndex].value)]);
+      };
 
       if (cr.isWindows || cr.isMac) {
         $('certificatesManageButton').onclick = function(event) {
           chrome.send('showManageSSLCertificates');
         };
       } else {
         $('certificatesManageButton').onclick = function(event) {
           OptionsPage.showPageByName('certificateManager');
           OptionsPage.showTab($('personal-certs-nav-tab'));
           chrome.send('coreOptionsUserMetricsAction',
@@ skipping 89 matching lines @@
     var selectCtl = $('defaultZoomLevel');
     for (var i = 0; i < selectCtl.options.length; i++) {
       if (selectCtl.options[i].value == value) {
         selectCtl.selectedIndex = i;
         return;
       }
     }
     selectCtl.selectedIndex = 4;  // 100%
   };
 
+  // Set the font size selected item.
+  AdvancedOptions.SetFontSize = function(fixed_font_size_value,
+      font_size_value) {
+    var selectCtl = $('defaultFontSize');
+

[csilv, 2010/12/22 20:56:53]

This looks good.  I would recommend changing it a little... put font size
comparison around the for loop.  ex:

if (fixed_font_size_value == font_size_value) {
  for (var i = 0; i < selectCtl.options.length; i++) {
    ...
  }
}

And then you only have one call to AddOrSelectCustomOption, so inline that into
this function.

[kmadhusu, 2010/12/22 21:19:08]

Done.

+    if (fixed_font_size_value != font_size_value) {
+      AddOrSelectCustomOption();
+      return;
+    }
+
+    for (var i = 0; i < selectCtl.options.length; i++) {
+      if (selectCtl.options[i].value == font_size_value) {
+        selectCtl.selectedIndex = i;
+        if ($('Custom'))
+          selectCtl.remove($('Custom').index);
+        return;
+      }
+    }
+    AddOrSelectCustomOption();
+  };
+
+  // Add/Select Custom Option in the font size label list.
+  function AddOrSelectCustomOption() {
+    var selectCtl = $('defaultFontSize');
+    if (!$('Custom')) {
+      var option = new Option(localStrings.getString('fontSizeLabelCustom'),
+                              -1, false, true);
+      option.setAttribute("id","Custom");
+      selectCtl.add(option);
+    }
+    $('Custom').selected = true;
+  };
+
   // Set the download path.
   AdvancedOptions.SetDownloadLocationPath = function(path) {
     if (!cr.isChromeOS)
       $('downloadLocationPath').value = path;
   };
 
   // Set the enabled state for the autoOpenFileTypesResetToDefault button.
   AdvancedOptions.SetAutoOpenFileTypesDisabledAttribute = function(disabled) {
     $('autoOpenFileTypesResetToDefault').disabled = disabled;
   };
@@ skipping 45 matching lines @@
       $('cloud-print-proxy-section').style.display = 'none';
     }
   };
 
   // Export
   return {
     AdvancedOptions: AdvancedOptions
   };
 
 });