Disable 'create shortcut' in newtab apps pulldown menu.

chrome/browser/resources/ntp/apps.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var MAX_APPS_PER_ROW = [];
 MAX_APPS_PER_ROW[LayoutMode.SMALL] = 4;
 MAX_APPS_PER_ROW[LayoutMode.NORMAL] = 6;
 
 // The URL prefix used in the app link 'ping' attributes.
 var PING_APP_LAUNCH_PREFIX = 'record-app-launch';
@@ skipping 17 matching lines @@
   var webStoreEntry, webStoreMiniEntry;
 
   // Hide menu options that are not supported on the OS or windowing system.
 
   // The "Launch as Window" menu option.
   $('apps-launch-type-window-menu-item').style.display =
       (data.disableAppWindowLaunch ? 'none' : 'inline');
 
   // The "Create App Shortcut" menu option.
   $('apps-create-shortcut-command-menu-item').style.display =
+      $('apps-create-shortcut-command-separator').style.display =
       (data.disableCreateAppShortcut ? 'none' : 'inline');

[arv (Not doing code reviews), 2010/12/20 19:01:08]

This looks wrong. The display of these should never be inline.

[kochi, 2010/12/21 06:09:33]

Good catch!
I created a follow-up CL at
http://codereview.chromium.org/6060003/

Could you review?

 
   appsMiniview.textContent = '';
   appsSectionContent.textContent = '';
 
   data.apps.sort(function(a,b) {
     return a.app_launch_index - b.app_launch_index;
   });
 
   clearClosedMenu(apps.menu);
   data.apps.forEach(function(app) {
@@ skipping 302 matching lines @@
     createWebStoreClosedMenuElement: function() {
       var a = document.createElement('a');
       a.textContent = localStrings.getString('web_store_title');
       a.href = localStrings.getString('web_store_url');
       a.style.backgroundImage = url('chrome://theme/IDR_PRODUCT_LOGO_16');
       a.className = 'item';
       return a;
     }
   };
 })();